Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added wysiwyg editor to the activity description fields #1129

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Added wysiwyg editor to the activity description fields #1129

wants to merge 2 commits into from

Conversation

SpookyBoy99
Copy link
Contributor

Implements #1125 and fixes #1124. It is not the most beautiful implementation but this was the most practical solution within the established ecosystem.

SilasPeters
SilasPeters requested changes Sep 15, 2024
View reviewed changes
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative. Even ctrl-z works! After testing, here are some remarks:

  1. I can't enter the s character in the description field.
  2. As you might have seen on whatsapp, the 'copy to whatsapp' does not convert/filter the HTML properly to markdown

@SpookyBoy99
Copy link
Contributor Author

Not being able to enter an s is probably a side effect from the PR #1095, it has some more issues unfortunately. The copy to WhatsApp filter I'll have to rewrite completely I'm afraid, probably using the Delta API from Quill. A quick solution for now however, would be to just copy the inner text which would just strip all the HTML.

@SilasPeters
Copy link
Member

@SpookyBoy99 what are your intentions on this PR?

@SpookyBoy99
Copy link
Contributor Author

It's not the greatest implementation of a WYSIWYG editor and the copy for WhatsApp functionality is pretty much broken. I am not sure if I have the time or will power to completely fix those issues, so I might just close this PR unless there is enough interest from the board.

@SpookyBoy99 SpookyBoy99 marked this pull request as draft January 7, 2025 13:34
@SilasPeters
Copy link
Member

I guess the product owners have the final call here @olafboekholt @TobiasDeBruijn . I don't have any strong opinions on this PR.

@TobiasDeBruijn
Copy link
Member

While definitely a nice to have, the copy for whatsapp feature is a must have. If you feel like it, please do implement! Though if you'd rather focus on other projects or issues, that is completely fine as well, then this PR can be closed.

@SpookyBoy99
Copy link
Contributor Author

I'll see what I can do during the 14 hour bus ride this weekend, if I don't manage to get it working by then I will just close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilasPeters SilasPeters SilasPeters requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wysiwyg formatting for emails and board post does not equal to the output
3 participants
@SpookyBoy99 @SilasPeters @TobiasDeBruijn